[Differential] [Request, 8 lines] D2058: Make TestXmlReader/TestXmlReaderWithoutSpaces handle translated error messages
kossebau (Friedrich W. H. Kossebau)
noreply at phabricator.kde.org
Fri Jul 1 14:57:44 BST 2016
kossebau created this revision.
kossebau added a reviewer: Calligra-Devel-list.
Restricted Application added projects: Kexi, Calligra: 3.0.
REVISION SUMMARY
Linking KI18n results in Qt translations being loaded on start. And
QXmlStreamReader, used internally by KoXmlDocument, returns translated error messages.
So running in a non-en locale still testing the english strings will fail.
Checking undocumented error strings is fragile already, so relying on a certain
translation context does not make things a lot worse.
TEST PLAN
Tests no longer fail with Qt translations installed and running in a non-en
locale.
REPOSITORY
rCALLIGRA Calligra
BRANCH
fixTestXmlReaderTestingTranslatedErrorMessages
REVISION DETAIL
https://phabricator.kde.org/D2058
AFFECTED FILES
libs/odf/tests/TestXmlReader.cpp
libs/odf/tests/TestXmlReaderWithoutSpaces.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, Calligra-Devel-list
Cc: staniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20160701/6eebabd1/attachment.htm>
More information about the calligra-devel
mailing list