<table><tr><td style="">kossebau created this revision.<br />kossebau added a reviewer: Calligra-Devel-list.<br />Restricted Application added projects: Kexi, Calligra: 3.0.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2058" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Linking KI18n results in Qt translations being loaded on start. And<br />
QXmlStreamReader, used internally by KoXmlDocument, returns translated error messages.<br />
So running in a non-en locale still testing the english strings will fail.</p>
<p>Checking undocumented error strings is fragile already, so relying on a certain<br />
translation context does not make things a lot worse.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tests no longer fail with Qt translations installed and running in a non-en<br />
locale.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rCALLIGRA Calligra</div></div></div><br /><div><strong>BRANCH</strong><div><div>fixTestXmlReaderTestingTranslatedErrorMessages</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2058" rel="noreferrer">https://phabricator.kde.org/D2058</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>libs/odf/tests/TestXmlReader.cpp<br />
libs/odf/tests/TestXmlReaderWithoutSpaces.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kossebau, Calligra-Devel-list<br /><strong>Cc: </strong>staniek<br /></div>