[Differential] [Updated] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

staniek (Jarosław Staniek) noreply at phabricator.kde.org
Sat Sep 19 22:48:35 BST 2015


staniek marked an inline comment as done.
staniek added a comment.

In https://phabricator.kde.org/D360#7130, @kossebau wrote:

> Not sure I would have moved the main.cpp into the other file, but there is no policy in Calligra about such utils apps, so if you prefer it like that, keep it as you did now. (I prefer having entry points in a separate file, even do main.cpp files for plugins, but I know that this is my personal style only. And as long the util app is sharing the same folder with other stuff, the main.cpp could be conflicting, so...).


Using the KF5 naming, this is a test, and our QTests are called autotests. There, tests/ contain (interactive) apps. Example:

  ktextwidgets/tests/ktextedittest.cpp

We're not yet following this scheme in calligra (no idea if we want this extra rename) but I use it in KDb, etc. I followed KF5 already. The third type of dir is example/ - a real-world app.

(that's for the record, sorry for repeating obvious things)

Thx!


REVISION DETAIL
  https://phabricator.kde.org/D360

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, rempt, kossebau
Cc: Calligra-Devel-list



More information about the calligra-devel mailing list