[Differential] [Commented On] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

[kossebau (Friedrich W. H. Kossebau)]

kossebau added a comment.

Not sure I would have moved the main.cpp into the other file, but there is no policy in Calligra about such utils apps, so if you prefer it like that, keep it as you did now. (I prefer having entry points in a separate file, even do main.cpp files for plugins, but I know that this is my personal style only. And as long the util app is sharing the same folder with other stuff, the main.cpp could be conflicting, so...).

So with the request to have to the fix to KoPropertiesTest in a separate commit, this patch here seems fine to me to go in. Still untested and only partially code-reviewed, as before, with same reasoning :)


INLINE COMMENTS
  libs/widgetutils/tests/CMakeLists.txt:8 This is fixed in a separate commit, right? If not, please make this a separate commit, for improved clear scopes of the atomic changes by commits.

REVISION DETAIL
  https://phabricator.kde.org/D360

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, rempt, kossebau
Cc: Calligra-Devel-list