[Differential] [Commented On] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets

[staniek (Jarosław Staniek)]

staniek added a comment.

In https://phabricator.kde.org/D360#7104, @kossebau wrote:

> While moving filedialogtester, could you please move it into the subdir tests/, so the normal dir only contains product code?


OK, I wanted to propose that.

> As you just moved the KoFileDialog class files (and updated used export macro), I have not really looked into the code, only the CMakeLists.txt changes. Also not tested, assuming things work as before as kowidgetutils is a public dep of kowidgets :)

> 

> With filedialogtester moved down to subdir tests/, seems fine to me and good to ship.


OK


REVISION DETAIL
  https://phabricator.kde.org/D360

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, rempt, kossebau
Cc: Calligra-Devel-list