Review Request 125509: TextTool: ignore Esc key so that it can be used to switch back to the interaction tool

David Faure faure at kde.org
Mon Oct 5 11:25:43 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125509/
-----------------------------------------------------------

(Updated Oct. 5, 2015, 10:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra and Thorsten Zachmann.


Changes
-------

Submitted with commit 857fbbc5ba295c84770ab1f21aa92a9c96ce6666 by David Faure to branch calligra/2.9.


Repository: calligra


Description
-------

I expected the "empty text" test to catch it, but actually Key_Escape generates
the text "\033".


Diffs
-----

  plugins/textshape/TextTool.cpp 8aa18917351c79b34e810fdbe29d229449cef856 

Diff: https://git.reviewboard.kde.org/r/125509/diff/


Testing
-------

Esc finally works ;)

I've been missing this since the flake redesign.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151005/537e76ec/attachment.htm>


More information about the calligra-devel mailing list