Review Request 125509: TextTool: ignore Esc key so that it can be used to switch back to the interaction tool
Camilla Boemann
cbr at boemann.dk
Sun Oct 4 13:27:40 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125509/#review86330
-----------------------------------------------------------
Ship it!
Ship It!
- Camilla Boemann
On Oct. 3, 2015, 5:21 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125509/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 5:21 p.m.)
>
>
> Review request for Calligra and Thorsten Zachmann.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> I expected the "empty text" test to catch it, but actually Key_Escape generates
> the text "\033".
>
>
> Diffs
> -----
>
> plugins/textshape/TextTool.cpp 8aa18917351c79b34e810fdbe29d229449cef856
>
> Diff: https://git.reviewboard.kde.org/r/125509/diff/
>
>
> Testing
> -------
>
> Esc finally works ;)
>
> I've been missing this since the flake redesign.
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151004/dfd65bb6/attachment.htm>
More information about the calligra-devel
mailing list