Review Request 125494: PictureShapeConfigWidget: ensure we only select existing files.
David Faure
faure at kde.org
Mon Oct 5 11:24:32 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125494/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 10:24 a.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra.
Changes
-------
Submitted with commit cf9eebce3757ea4c0e9c551e3f2c016ce930a3e6 by David Faure to branch calligra/2.9.
Repository: calligra
Description
-------
I somehow ended up selecting the parent directory in some of my tests...
And with this fix, typing a non-existing filename leads to an error message
from KFileWidget itself, which then doesn't close, letting the user have
another try.
Diffs
-----
plugins/pictureshape/PictureShapeConfigWidget.cpp e8cf8ccff228aa7a50a6ec58a2a1df7ede1a2ee0
Diff: https://git.reviewboard.kde.org/r/125494/diff/
Testing
-------
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151005/af6964e5/attachment.htm>
More information about the calligra-devel
mailing list