Review Request 125494: PictureShapeConfigWidget: ensure we only select existing files.
Thorsten Zachmann
t.zachmann at zagge.de
Sat Oct 3 04:32:36 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125494/#review86269
-----------------------------------------------------------
Ship it!
Looks good please commit. Thanks for the patch. Boudewijn can you please forward port the fixes.
- Thorsten Zachmann
On Oct. 2, 2015, 9:23 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125494/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 9:23 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> I somehow ended up selecting the parent directory in some of my tests...
> And with this fix, typing a non-existing filename leads to an error message
> from KFileWidget itself, which then doesn't close, letting the user have
> another try.
>
>
> Diffs
> -----
>
> plugins/pictureshape/PictureShapeConfigWidget.cpp e8cf8ccff228aa7a50a6ec58a2a1df7ede1a2ee0
>
> Diff: https://git.reviewboard.kde.org/r/125494/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20151003/a6be2de6/attachment.htm>
More information about the calligra-devel
mailing list