Review Request 123699: Changed a few labels in kexi's forms and reports designers

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123699/#review80135
-----------------------------------------------------------


Good.

Translatable string changes are frozen in 2.9 unfortunately, the junior jobs were defined when it was possible to change them.
I'd like to ask for applying kexi/plugins/* changes to 'frameworks' branch instead and plugins/reporting/web/KoReportWebPlugin.cpp to kreport.git [https://community.kde.org/Kexi/Porting_to_Qt%26KF_5#kreport].


kexi/plugins/forms/kexiformmanager.cpp (line 394)
<https://git.reviewboard.kde.org/r/123699/#comment54975>

    While we're at this, I also recommend to change \"%1\" to <interface>%1</interface>.
    
    More info at https://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics.


- Jarosław Staniek


On May 9, 2015, 1:24 p.m., Karol Pawlowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123699/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 1:24 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Small improvements to kexi forms and reports. Tasks 4th, 9th and 10th from https://community.kde.org/Kexi/Junior_Jobs/Small_report_improvements
> 
> - Rename visible caption of "Web" to "Web Page" ("Check" to "Check Box" was done previously)
> - Change label for the data source combo in report designer's "Internal Source" to "Report's data source:"
> - Change label in form designer's 'data source' tab from "Form's data source" to "Form's data source:". Also in report designer's 'data source' tab change "Source Type:" to "Source type:" and "External Source:" to "External source:".
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/forms/kexidatasourcepage.cpp 82bb7b4 
>   kexi/plugins/forms/kexiformmanager.cpp 6906b00 
>   kexi/plugins/reports/kexisourceselector.cpp edf02eb 
>   plugins/reporting/web/KoReportWebPlugin.cpp 145e987 
> 
> Diff: https://git.reviewboard.kde.org/r/123699/diff/
> 
> 
> Testing
> -------
> 
> See that labels are really changed as requested
> 
> 
> Thanks,
> 
> Karol Pawlowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150509/7c74ef47/attachment.htm>