<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123699/">https://git.reviewboard.kde.org/r/123699/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Translatable string changes are frozen in 2.9 unfortunately, the junior jobs were defined when it was possible to change them.
I'd like to ask for applying kexi/plugins/* changes to 'frameworks' branch instead and plugins/reporting/web/KoReportWebPlugin.cpp to kreport.git [https://community.kde.org/Kexi/Porting_to_Qt%26KF_5#kreport].</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123699/diff/1/?file=367937#file367937line394" style="color: black; font-weight: bold; text-decoration: underline;">kexi/plugins/forms/kexiformmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KexiFormManager::setFormDataSource(const QString& partClass, const QString& name)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">394</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">i18n</span><span class="p">(</span><span class="s">"Set <span class="hl">F</span>orm's <span class="hl">D</span>ata <span class="hl">S</span>ource to </span><span class="se">\"</span><span class="s">%1</span><span class="se">\"</span><span class="s">"</span><span class="p">,</span> <span class="n">name</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">394</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">i18n</span><span class="p">(</span><span class="s">"Set <span class="hl">f</span>orm's <span class="hl">d</span>ata <span class="hl">s</span>ource to </span><span class="se">\"</span><span class="s">%1</span><span class="se">\"</span><span class="s">"</span><span class="p">,</span> <span class="n">name</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While we're at this, I also recommend to change \"%1\" to <interface>%1</interface>.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">More info at https://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics.</p></pre>
</div>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On May 9th, 2015, 1:24 p.m. CEST, Karol Pawlowski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Jarosław Staniek and Wojciech Kosowicz.</div>
<div>By Karol Pawlowski.</div>
<p style="color: grey;"><i>Updated May 9, 2015, 1:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Small improvements to kexi forms and reports. Tasks 4th, 9th and 10th from https://community.kde.org/Kexi/Junior_Jobs/Small_report_improvements</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Rename visible caption of "Web" to "Web Page" ("Check" to "Check Box" was done previously)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Change label for the data source combo in report designer's "Internal Source" to "Report's data source:"</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Change label in form designer's 'data source' tab from "Form's data source" to "Form's data source:". Also in report designer's 'data source' tab change "Source Type:" to "Source type:" and "External Source:" to "External source:".</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See that labels are really changed as requested</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/forms/kexidatasourcepage.cpp <span style="color: grey">(82bb7b4)</span></li>
<li>kexi/plugins/forms/kexiformmanager.cpp <span style="color: grey">(6906b00)</span></li>
<li>kexi/plugins/reports/kexisourceselector.cpp <span style="color: grey">(edf02eb)</span></li>
<li>plugins/reporting/web/KoReportWebPlugin.cpp <span style="color: grey">(145e987)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123699/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>