Review Request 123651: Kexi: Improvements for reports internal source combobox

[Jarosław Staniek]

> On May 8, 2015, 10:57 p.m., Kamil Łysik wrote:
> > I accidentally pushed this commit - sorry. I reverted it.
> > If anybody have some free time, please review this commit.

No problem but in the future it's better to review after such accidental commit. Now we'll have two unnecessary commits instead of one too early pushed.

I recommend using 'git cherry -v' to see what is going to be pushed. I am also using git-push-until which pushed only commits until the one specified:

#!/bin/bash
# $1: commit, $2: branch

if [ $# -ne 2 ] ; then
    echo "Usage \$1: commit, \$2: branch"
    exit 0
fi

git push origin $1:$2


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123651/#review80106
-----------------------------------------------------------


On May 8, 2015, 10:50 p.m., Kamil Łysik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123651/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 10:50 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 347127
>     http://bugs.kde.org/show_bug.cgi?id=347127
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Kexi: Improvements for reports internal source combobox
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/CMakeLists.txt d563e17 
>   kexi/plugins/reports/InternalSourceSelector.h 384edc2 
>   kexi/plugins/reports/InternalSourceSelector.cpp 1729527 
>   kexi/plugins/reports/kexidbreportdata.h 5a5d367 
>   kexi/plugins/reports/kexidbreportdata.cpp d5cd54e 
>   kexi/plugins/reports/kexireportpart.cpp 88375c6 
>   kexi/plugins/reports/kexisourceselector.h 6dbf91f 
>   kexi/plugins/reports/kexisourceselector.cpp edf02eb 
>   kexi/widget/KexiDataSourceComboBox.cpp 112413b 
> 
> Diff: https://git.reviewboard.kde.org/r/123651/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kamil Łysik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150508/a4017a6c/attachment.htm>