<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123651/">https://git.reviewboard.kde.org/r/123651/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 8th, 2015, 10:57 p.m. CEST, <b>Kamil Łysik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I accidentally pushed this commit - sorry. I reverted it.
If anybody have some free time, please review this commit.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No problem but in the future it's better to review after such accidental commit. Now we'll have two unnecessary commits instead of one too early pushed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I recommend using 'git cherry -v' to see what is going to be pushed. I am also using git-push-until which pushed only commits until the one specified:</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">!/bin/bash</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$1: commit, $2: branch</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if [ $# -ne 2 ] ; then
echo "Usage \$1: commit, \$2: branch"
exit 0
fi</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">git push origin $1:$2</p></pre>
<br />
<p>- Jarosław</p>
<br />
<p>On May 8th, 2015, 10:50 p.m. CEST, Kamil Łysik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Kamil Łysik.</div>
<p style="color: grey;"><i>Updated May 8, 2015, 10:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=347127">347127</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kexi: Improvements for reports internal source combobox</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/reports/CMakeLists.txt <span style="color: grey">(d563e17)</span></li>
<li>kexi/plugins/reports/InternalSourceSelector.h <span style="color: grey">(384edc2)</span></li>
<li>kexi/plugins/reports/InternalSourceSelector.cpp <span style="color: grey">(1729527)</span></li>
<li>kexi/plugins/reports/kexidbreportdata.h <span style="color: grey">(5a5d367)</span></li>
<li>kexi/plugins/reports/kexidbreportdata.cpp <span style="color: grey">(d5cd54e)</span></li>
<li>kexi/plugins/reports/kexireportpart.cpp <span style="color: grey">(88375c6)</span></li>
<li>kexi/plugins/reports/kexisourceselector.h <span style="color: grey">(6dbf91f)</span></li>
<li>kexi/plugins/reports/kexisourceselector.cpp <span style="color: grey">(edf02eb)</span></li>
<li>kexi/widget/KexiDataSourceComboBox.cpp <span style="color: grey">(112413b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123651/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>