Review Request 123132: Fix cmake error when configuring Calligra - Marble related

Jarosław Staniek staniek at kde.org
Wed Mar 25 22:29:52 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123132/
-----------------------------------------------------------

Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.


Bugs: 345318
    http://bugs.kde.org/show_bug.cgi?id=345318


Repository: calligra


Description
-------

- Move handling of minimum version check to FindCalligraMarble.cmake
- Make marble not found if 'minimum version' constraint isn't met
- Cache variables detected for marble


Diffs
-----

  CMakeLists.txt ba8e73128e19fad7e5aaebea38f0062c24075876 
  cmake/modules/FindCalligraMarble.cmake 08ce469d69950a811134b6b76e1f3183c6256c88 

Diff: https://git.reviewboard.kde.org/r/123132/diff/


Testing
-------

Configures well, tested by the reporter too


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150325/6e66eb9e/attachment.htm>


More information about the calligra-devel mailing list