About to remove koproperty, koreport and calligradb commits

[Jaroslaw Staniek]

Thanks Friedrich, noted down your hints. I plan to add the lines in
extra commits.

On 23 March 2015 at 22:30, Friedrich W. H. Kossebau <kossebau at kde.org> wrote:
> Am Montag, 23. März 2015, 02:19:16 schrieb Jaroslaw Staniek:
>> Hi,
>> Please take a look at removed koproperty, koreport and calligradb
>> commits before I cherry pick these to frameworks branch. Did I miss
>> something?
>>
>> The three commits in the frameworks-staniek branch:
>>
>> + 40b62deaebc2c61e07d4e27beb2421617be046a4 Remove the koproperty lib,
>> it will be replaced by external KProperty
>
> CMakeLists.txt:
> Add in the respective sections (compare e.g. with KGantt):
>
> --- 8< ---
> ##
> ## Test for KProperty
> ##
> macro_optional_find_package(KProperty)
> macro_log_feature(KProperty_FOUND "KProperty" "Library for SOMETHING PROPER
> HERE" "http://www.kexi.org/" FALSE "" "Required by Kexi and Plan")
> --- 8< ---
>
> --- 8< ---
> calligra_drop_product_on_bad_condition( APP_KEXI
>             KProperty_FOUND "KProperty devel not found"
> )
> --- 8< ---
> and the line with KProperty_FOUND also to the existing drop line with APP_PLAN
>
> plan/libs/ui/CMakeLists.txt:
> Please also add KProperty, not only remove ${KOPROPERTY_LIBS}
>
>> + 090b9619aa18fc62d6b0d720518a61f76c1342ab Remove the koreport lib
>> +plugins, it will be replaced by external KReport
>
> CMakeLists.txt:
>
> Same as with KProperty: add a test for KReport
>
> Extend the drop lines for APP_KEXI and APP_PLAN with
>     KReport_FOUND "KReport devel not found"
>
>
>> + 390bf5be870c77bf4b82d403294299a12dcb53a7 Remove the calligradb lib,
>> kexidb plugins; will be replaced by Predicate
>
> CMakeLists.txt:
> Same as with KProperty: add a test for Predicate
>
> Extend drop line for APP_KEXI with
>             Predicate_FOUND "Predicate devel not found"
>
> Those lines should give a rough draft of what can be expected in the end.
>
> Othewise looks like a good cleanup to me. Not tested if it breaks the build
> (no time right now), but any current break should be quickly fixable.
>
> So IMHO go and make room for the new db-related grown-up libs KProperty,
> KReport and Predicate!
>
> Cheers
> Friedrich
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel



-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek