Your commit to KOffice/KDChart, why the additional MarkerSizeMode values?

Friedrich W. H. Kossebau kossebau at kde.org
Sat Jun 13 20:47:06 BST 2015


Hi Johannes,

it's almost 5 years ago, but perhaps you remember.

When you worked on KOffice, you once did this commit:
http://marc.info/?l=kde-commits&m=128723905226254

Quick question: do you remember why you added all those other value to the 
enum MarkerSizeMode?
>From what I see only the default "AbsoluteSize" and "AbsoluteSizeScaled" + 
"RelativeToDiagramWidthHeightMin" are used. 

Did you add "RelativeToDiagramWidth" and "RelativeToDiagramHeight" because it 
felt more complete, given the "RelativeToDiagramWidthHeightMin" option? Or are 
there use cases you had in mind?

Background:

Calligra, taking a lot of KOffice heritage, currently is ported to Qt5, and a 
snapshot of KDChart is now tried to be run as separate repo, named KDiagram, 
containing the libs KChart and KGantt (from KDChart and KDGantt).
Of course now all custom patches to the KDChart snapshots need to be 
incorporated from the different projects that used snapshots so far and are 
now turning to use that separate repo.

And your commit from former times would be one that needs application to 
KDiagram. Already prepared as review request, see 
https://git.reviewboard.kde.org/r/124091/

Given it would become public API this needs well-informed reasoning :) Thus 
this email. Hope you are doing well, will find time to help out and have good 
memories of that commit :)

Cheers
Friedrich



More information about the calligra-devel mailing list