Review Request 122238: KoStyleManager independence from kotext

[Camilla Boemann]

> On Jan. 25, 2015, 10:41 a.m., Inge Wallin wrote:
> > libs/kotext/OdfTextTrackStyles.cpp, line 30
> > <https://git.reviewboard.kde.org/r/122238/diff/3/?file=344658#file344658line30>
> >
> >     Hmm, do we have more than one KoStyleManager? I thought the one handled all styles.

well some apps might have more than one KoDocument so yes we might have more than one KoStyleManager too :)


> On Jan. 25, 2015, 10:41 a.m., Inge Wallin wrote:
> > libs/kotext/OdfTextTrackStyles.h, line 34
> > <https://git.reviewboard.kde.org/r/122238/diff/3/?file=344657#file344657line34>
> >
> >     Some questions:
> >      - Who is supposed to own instance(s?) of this class?
> >      - Where does it fit in the big scheme of things?
> >      - what does 'handle' in 'we handle them all' mean? Relayout? Store changes somewhere?

I would prefer not documenting how others use this class - but right now a KoTextDocument makes sure there is an instance when we set the KoStyleManager on the KoTextDocument

and handle means: Store changes and apply them to qtextdocuments as needed


- Camilla


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122238/#review74689
-----------------------------------------------------------


On Jan. 25, 2015, 12:40 a.m., Camilla Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122238/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2015, 12:40 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Make KoStyleManager independent of rest of libs/kotext - making it possible to move it to libs/odf
> also fixes a bug that stylechanges were never applied to the document
> 
> 
> Diffs
> -----
> 
>   libs/kotext/CMakeLists.txt bfb0b2d 
>   libs/kotext/KoTextDocument.cpp 07a47dc 
>   libs/kotext/OdfTextTrackStyles.h PRE-CREATION 
>   libs/kotext/OdfTextTrackStyles.cpp PRE-CREATION 
>   libs/kotext/commands/ChangeStylesCommand.h 3762715 
>   libs/kotext/commands/ChangeStylesCommand.cpp 771caae 
>   libs/kotext/commands/ChangeStylesMacroCommand.h 340ba12 
>   libs/kotext/commands/ChangeStylesMacroCommand.cpp 66f5326 
>   libs/kotext/styles/ChangeFollower.h 5786541 
>   libs/kotext/styles/ChangeFollower.cpp 7930cfe 
>   libs/kotext/styles/KoStyleManager.h e1b400c 
>   libs/kotext/styles/KoStyleManager.cpp 86108d6 
>   libs/textlayout/KoTextShapeData.cpp c51ec6e 
>   sheets/Map.cpp a4fcc7c 
> 
> Diff: https://git.reviewboard.kde.org/r/122238/diff/
> 
> 
> Testing
> -------
> 
> only basic editing and seeing that undo/redo works and that changes are now actually appied to the document
> 
> 
> Thanks,
> 
> Camilla Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150125/811585bf/attachment.htm>