Review Request 122238: KoStyleManager independence from kotext

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122238/#review74689
-----------------------------------------------------------

Ship it!


Much much clearer!  

I do have some comments below that you might want to look at, and perhaps write a little doc.  But I see no need for another round of review.


libs/kotext/OdfTextTrackStyles.h
<https://git.reviewboard.kde.org/r/122238/#comment51777>

    Some questions:
     - Who is supposed to own instance(s?) of this class?
     - Where does it fit in the big scheme of things?
     - what does 'handle' in 'we handle them all' mean? Relayout? Store changes somewhere?



libs/kotext/OdfTextTrackStyles.cpp
<https://git.reviewboard.kde.org/r/122238/#comment51778>

    Hmm, do we have more than one KoStyleManager? I thought the one handled all styles.



libs/kotext/OdfTextTrackStyles.cpp
<https://git.reviewboard.kde.org/r/122238/#comment51779>

    Thank you for this naming. :)
    
    Maybe we can make it a standard within calligra?



libs/kotext/OdfTextTrackStyles.cpp
<https://git.reviewboard.kde.org/r/122238/#comment51780>

    From conversation on IRC I learned that one command is supposed to track all changes of all styles from one call of the visual style manager.
    
    But this doesn't fit because here we only send one changed style to be stored in the command.
    
    Update: I learned later that there is macro that takes care of this, so maybe just document that a bit and it's fine.


- Inge Wallin


On Jan. 25, 2015, 1:40 a.m., Camilla Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122238/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2015, 1:40 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Make KoStyleManager independent of rest of libs/kotext - making it possible to move it to libs/odf
> also fixes a bug that stylechanges were never applied to the document
> 
> 
> Diffs
> -----
> 
>   libs/kotext/CMakeLists.txt bfb0b2d 
>   libs/kotext/KoTextDocument.cpp 07a47dc 
>   libs/kotext/OdfTextTrackStyles.h PRE-CREATION 
>   libs/kotext/OdfTextTrackStyles.cpp PRE-CREATION 
>   libs/kotext/commands/ChangeStylesCommand.h 3762715 
>   libs/kotext/commands/ChangeStylesCommand.cpp 771caae 
>   libs/kotext/commands/ChangeStylesMacroCommand.h 340ba12 
>   libs/kotext/commands/ChangeStylesMacroCommand.cpp 66f5326 
>   libs/kotext/styles/ChangeFollower.h 5786541 
>   libs/kotext/styles/ChangeFollower.cpp 7930cfe 
>   libs/kotext/styles/KoStyleManager.h e1b400c 
>   libs/kotext/styles/KoStyleManager.cpp 86108d6 
>   libs/textlayout/KoTextShapeData.cpp c51ec6e 
>   sheets/Map.cpp a4fcc7c 
> 
> Diff: https://git.reviewboard.kde.org/r/122238/diff/
> 
> 
> Testing
> -------
> 
> only basic editing and seeing that undo/redo works and that changes are now actually appied to the document
> 
> 
> Thanks,
> 
> Camilla Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150125/39f56fff/attachment.htm>