Review Request 121868: Remove uncompiled files that include Q3 or K3 headers
Jarosław Staniek
staniek at kde.org
Mon Jan 5 21:02:06 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121868/#review73205
-----------------------------------------------------------
Ship it!
Almost good, thanks for caring. In the commit message please list all classes removed in case we'll want to find them for reference later.
kexi/plugins/forms/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121868/#comment50916>
extra tabs not needed
- Jarosław Staniek
On Jan. 5, 2015, 9:38 p.m., Adam Pigg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121868/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2015, 9:38 p.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Removed uncompiled files that include Q3*
>
> Becuase subform is marked as todo, make it compile without Q3
> but leave it disabled as its untested and not exposed in the gui
>
>
> Diffs
> -----
>
> kexi/plugins/forms/CMakeLists.txt de0c7b3
> kexi/plugins/forms/widgets/kexidbdateedit.h 77e12f3
> kexi/plugins/forms/widgets/kexidbdateedit.cpp 962e901
> kexi/plugins/forms/widgets/kexidbdatetimeedit.h 42b069a
> kexi/plugins/forms/widgets/kexidbdatetimeedit.cpp ae145ce
> kexi/plugins/forms/widgets/kexidbsubform.h b404b42
> kexi/plugins/forms/widgets/kexidbsubform.cpp 856c0f1
> kexi/plugins/forms/widgets/kexidbtimeedit.h 704197d
> kexi/plugins/forms/widgets/kexidbtimeedit.cpp 4cbbf94
> kexi/widget/CMakeLists.txt 69d842f
> kexi/widget/pixmapcollection.h a8e4878
> kexi/widget/pixmapcollection.cpp 853b032
>
> Diff: https://git.reviewboard.kde.org/r/121868/diff/
>
>
> Testing
> -------
>
> Checked builds ok
>
>
> Thanks,
>
> Adam Pigg
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150105/55903a7d/attachment.htm>
More information about the calligra-devel
mailing list