<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121868/">https://git.reviewboard.kde.org/r/121868/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Almost good, thanks for caring. In the commit message please list all classes removed in case we'll want to find them for reference later.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121868/diff/1/?file=338479#file338479line90" style="color: black; font-weight: bold; text-decoration: underline;">kexi/plugins/forms/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">widgets/kexidbtextedit.cpp</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="indent">>></span> <span class="s">widgets/kexidbtextedit.cpp</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">extra tabs not needed</p></pre>
</div>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On January 5th, 2015, 9:38 p.m. CET, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2015, 9:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Removed uncompiled files that include Q3*</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Becuase subform is marked as todo, make it compile without Q3
but leave it disabled as its untested and not exposed in the gui</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checked builds ok</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/forms/CMakeLists.txt <span style="color: grey">(de0c7b3)</span></li>
<li>kexi/plugins/forms/widgets/kexidbdateedit.h <span style="color: grey">(77e12f3)</span></li>
<li>kexi/plugins/forms/widgets/kexidbdateedit.cpp <span style="color: grey">(962e901)</span></li>
<li>kexi/plugins/forms/widgets/kexidbdatetimeedit.h <span style="color: grey">(42b069a)</span></li>
<li>kexi/plugins/forms/widgets/kexidbdatetimeedit.cpp <span style="color: grey">(ae145ce)</span></li>
<li>kexi/plugins/forms/widgets/kexidbsubform.h <span style="color: grey">(b404b42)</span></li>
<li>kexi/plugins/forms/widgets/kexidbsubform.cpp <span style="color: grey">(856c0f1)</span></li>
<li>kexi/plugins/forms/widgets/kexidbtimeedit.h <span style="color: grey">(704197d)</span></li>
<li>kexi/plugins/forms/widgets/kexidbtimeedit.cpp <span style="color: grey">(4cbbf94)</span></li>
<li>kexi/widget/CMakeLists.txt <span style="color: grey">(69d842f)</span></li>
<li>kexi/widget/pixmapcollection.h <span style="color: grey">(a8e4878)</span></li>
<li>kexi/widget/pixmapcollection.cpp <span style="color: grey">(853b032)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121868/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>