Review Request 122153: KD Chart

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122153/#review76031
-----------------------------------------------------------

Ship it!


I do not have a KDAB account. But I see those changes in the 2.5.1 codebase I got access to, so think these patches can be commited, thanks for coming up with them here.

Yes, Calligra’s kdchart and kdgantt files are out-of-date. Noone is currently working on updating them for the upcoming 2.9 release of Calligra.

But, things are better for the version oft that: for Calligra 3.0 with its port to Qt5/KF, there will be a KDE-fied version of latest KDChart/KDGantt available, see http://lists.kde.org/?l=kde-core-devel&m=142335191017238&w=2 .

So, please check that one issue I commented on, then push to 2.9 branch. Do you have a KDE git commit rights? Otherwise I would push for you.


3rdparty/kdchart/src/KDChartStockDiagram_p.cpp
<https://git.reviewboard.kde.org/r/122153/#comment52468>

    `<= 360` or `< 360`? The KDChart 2.5.1 dump used for KDiagram has `< 360`.


- Friedrich W. H. Kossebau


On Jan. 19, 2015, 5:51 nachm., Stephen Leibowitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122153/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 5:51 nachm.)
> 
> 
> Review request for Calligra, Boudewijn Rempt and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> These patches are also being made at kdab.com. Those who have a KDAB account can see the discussion in “Suggested Changes to KD Chart” at 
> https://quality.kdab.com/browse/KDCH-1020
> 
> Calligra’s kdchart and kdgantt files are out-of-date, even with the patches from the above paragraph. For example, “Compiler warnings” at
> http://mail.kde.org/pipermail/calligra-devel/2015-January/012762.html
> mentioned an error in KDChartPieDiagram.cpp. But the error is in a private function that was removed from the latest version (2.5.1) of KD Chart. KDAB will not patch previous versions. See “PieDiagram::drawPieSurface” at
> https://quality.kdab.com/browse/KDCH-1023
> 
> KDAB makes available source code for the latest and earlier versions of its KD Chart and other GPL licensed software at http://docs.kdab.com/
> 
> 
> Diffs
> -----
> 
>   3rdparty/kdchart/src/KDChartLayoutItems.cpp 095d2cd 
>   3rdparty/kdchart/src/KDChartStockDiagram_p.cpp d8636d7 
> 
> Diff: https://git.reviewboard.kde.org/r/122153/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephen Leibowitz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150214/3c96aa9e/attachment.htm>