<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122153/">https://git.reviewboard.kde.org/r/122153/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do not have a KDAB account. But I see those changes in the 2.5.1 codebase I got access to, so think these patches can be commited, thanks for coming up with them here.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, Calligra’s kdchart and kdgantt files are out-of-date. Noone is currently working on updating them for the upcoming 2.9 release of Calligra.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But, things are better for the version oft that: for Calligra 3.0 with its port to Qt5/KF, there will be a KDE-fied version of latest KDChart/KDGantt available, see http://lists.kde.org/?l=kde-core-devel&m=142335191017238&w=2 .</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, please check that one issue I commented on, then push to 2.9 branch. Do you have a KDE git commit rights? Otherwise I would push for you.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122153/diff/1/?file=343184#file343184line293" style="color: black; font-weight: bold; text-decoration: underline;">3rdparty/kdchart/src/KDChartStockDiagram_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void StockDiagram::Private::drawOHLCBar( int dataset, const CartesianDiagramDataCompressor::DataPoint &open,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">293</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="p">(</span> <span class="n">angle</span> <span class="o">>=</span> <span class="mi">90</span> <span class="o">&&</span> <span class="n">angle</span> <span class="o"><</span> <span class="mi">180</span> <span class="p">)</span> <span class="o">||</span> <span class="p">(</span> <span class="n">angle</span> <span class="o">>=</span> <span class="mi">270</span> <span class="o">&&</span> <span class="n">angle</span> <span class="o"><</span><span class="hl"> </span><span class="mi">0</span> <span class="p">)</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">293</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="p">(</span> <span class="n">angle</span> <span class="o">>=</span> <span class="mi">90</span> <span class="o">&&</span> <span class="n">angle</span> <span class="o"><</span> <span class="mi">180</span> <span class="p">)</span> <span class="o">||</span> <span class="p">(</span> <span class="n">angle</span> <span class="o">>=</span> <span class="mi">270</span> <span class="o">&&</span> <span class="n">angle</span> <span class="o"><<span class="hl">=</span></span><span class="hl"> </span><span class="mi"><span class="hl">36</span>0</span> <span class="p">)</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;"><= 360</code> or <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">< 360</code>? The KDChart 2.5.1 dump used for KDiagram has <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">< 360</code>.</p></pre>
</div>
</div>
<br />
<p>- Friedrich W. H. Kossebau</p>
<br />
<p>On Januar 19th, 2015, 5:51 nachm. UTC, Stephen Leibowitz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Boudewijn Rempt and Jarosław Staniek.</div>
<div>By Stephen Leibowitz.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2015, 5:51 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These patches are also being made at kdab.com. Those who have a KDAB account can see the discussion in “Suggested Changes to KD Chart” at
https://quality.kdab.com/browse/KDCH-1020</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Calligra’s kdchart and kdgantt files are out-of-date, even with the patches from the above paragraph. For example, “Compiler warnings” at
http://mail.kde.org/pipermail/calligra-devel/2015-January/012762.html
mentioned an error in KDChartPieDiagram.cpp. But the error is in a private function that was removed from the latest version (2.5.1) of KD Chart. KDAB will not patch previous versions. See “PieDiagram::drawPieSurface” at
https://quality.kdab.com/browse/KDCH-1023</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDAB makes available source code for the latest and earlier versions of its KD Chart and other GPL licensed software at http://docs.kdab.com/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>3rdparty/kdchart/src/KDChartLayoutItems.cpp <span style="color: grey">(095d2cd)</span></li>
<li>3rdparty/kdchart/src/KDChartStockDiagram_p.cpp <span style="color: grey">(d8636d7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122153/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>