Review Request 123943: Port KoDocumentEntry::name() and mimeTypes() to KF5

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123943/#review84605
-----------------------------------------------------------


Hi Peter, thanks for your patch. Sorry, seems everyone missed to notice it so far. Possibly because we were concentrated to look at phabricator.kde.org which Calligra was testing out as pilot contributor.
Next time please make more noise if noone reacts in a week :) E.g. by adding a "ping" to the review request.
The TODOs that your patch fixes have already been fixed with similar code. So may I please ask you to close this review request as discarded (only the author seems to be able to do it).

- Friedrich W. H. Kossebau


On May 30, 2015, 10:23 a.m., Peter Simonsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123943/
> -----------------------------------------------------------
> 
> (Updated May 30, 2015, 10:23 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Getting the data from QPluginLoader::metaData() which contains the entries from the desktop file.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoDocumentEntry.cpp f24a7ef 
> 
> Diff: https://git.reviewboard.kde.org/r/123943/diff/
> 
> 
> Testing
> -------
> 
> Verified name() output the Name entry value from the desktop file and mimeTypes() the MimeType entry value.
> 
> 
> Thanks,
> 
> Peter Simonsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150830/d0198658/attachment.htm>