Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Jaroslaw Staniek]

On 30 August 2015 at 10:29, Boudewijn Rempt <boud at valdyas.org> wrote:
> On Sun, 30 Aug 2015, Dmitry Kazakov wrote:
>
>> Hi, Friedrich!
>>
>> I have several points against total reformatting of everything.
>>
>> 1) We are planning to alpha-release LevelOfDetail and Animation
>> functionality soon for users to test. And we cannot base this
>> version on Frameworks, because the latter one has no decent tablet support
>> on Linux (Qt5 makes the line look jittery and we have no
>> decision yet how to fix that). So we cannot merge it in atm.
>
>
> You _have_ to. You can't go on building the animation branch against 2.9
> and expect to be able to merge it to master later on. There will be too
> many changes, not just whitespace cleanups. It's a pity that tablet support
> isn't fixed yet, but that's not a reason not to move feature development
> to the master/kf5/qt5 branch. We'll have to make sure tablet support is good
> again anyway.
>
>> 2) I am personally against of automated whitespace reformatting, because
>> it pollutes history of files without any use. Includes,
>> slots, forward declarations reformattings are ok. Whitespace no.
>
>
> There is a lot of use in whitespace cleanup: it makes the code
> consistent and readable.

Yes, we discussed that a bit a while ago. Initially I was critical
too. But whitespace changes can be ignored when generating diff _and_
blame (the -w option). Anyone can add this flag in git options for
diff/blame. I'd do so.

I'd like to note that we don't have a proven formatting tool for now
for all C++ elements. astyle got broken, and clang formatter can be
better but we need an expert. Missing things may be minor but we can't
make the result worse in problematic areas than the original. Not even
KF5 has a formatting tool, last I checked.

>> 3) Renaming files into CamesCaseStyle.cpp instead of underscore_style.cpp
>> will break my workflow. You have to expect me to spent at
>> least 2 working days on readjusting my workflow. I'm ok with it, though I
>> would prefer to spend this time on something more useful
>> for Krita.
>
>
> Well, we can do two things, after we've split up the repositories:
> rename everything to camelcase, or everything to underscores. As
> for me, Qt Creator makes it much easier to work with files that have the
> same names as the class themselves.

+ We're in Qt/KF5-centric world where CamelCase is used.

>
> Boudewijn
>
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel



-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek