Review Request 124927: Fix encoding of import filters for Applix* files

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124927/
-----------------------------------------------------------

(Updated Aug. 27, 2015, 9:54 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra and David Faure.


Changes
-------

Submitted with commit 15522107ac64ea63c59eaa226cd0cc03ec1edd98 by Friedrich W. H. Kossebau to branch calligra/2.9.


Repository: calligra


Description
-------

The sources files of the Applix* import filters had been stored in iso8859-15. In the methods to convert characters from Applix-style encoding to a QChar the mapping was done by assigning respective `char`s to a QChar, with the `char`s mostly being in the upper half of the iso8859-15 table.
Not sure if this ever worked in Qt4 (perhaps worked with older Qt), at least the docu does not really tell what decoder is used for the `QChar(char ch)` constructor.

So this patch converts the source files to UTF-8 and also changes the values used for mapping to the Unicode code point code. Compiles at leas here :) And my sample aw files still are imported with same quality as before. Just, they all seem to lack any non-latin1 characters, so I cannot test how the filters changed to . Experimented with manual editing of the raw aw files, but not sure if I fooled myself, so would prefer real files.

David, you are the only one known with access to ApplixWords/ApplixSpread, could you tell if this patch improves or breaks things?
(The .aw files created with AbiWord for tests sadly seem all to be imported as empty documents always, no idea why)


Diffs
-----

  filters/sheets/applixspread/applixspreadimport.cc d3db02a 
  filters/words/applixword/applixwordimport.cc c890cfa 

Diff: https://git.reviewboard.kde.org/r/124927/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150827/ba10ac5c/attachment.htm>