Review Request 123195: fix various bugs related to footnotes

Camilla Boemann cbr at boemann.dk
Thu Apr 16 09:01:26 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123195/
-----------------------------------------------------------

(Updated April 16, 2015, 8:01 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Changes
-------

Submitted with commit fc7b878f206fbf4e84e69bd18b2932eaa9c6e76e by C. Boemann to branch calligra/2.9.


Repository: calligra


Description
-------

The footnotes and endnotes were not displayed using the correct styles. We had just hard coded them to be shown using
    superscript, but they should be done using the styles specified by the notes configuration.
    
    The same applies to the paragraph style of the note itself - but since this is just a default we didn't see any problem
    when loading files, only when adding our own footnotes.
    
    Now netiher of the 3 styles specified by the notes configuraion needs to be present in files, and indeed are not present in
    our templates, so what LO does is add some styles. We do the same with these 6 styles
    
    Footnote : based on default paragraph
    Footnote Symbol : Applied to the id in the footnote itself - just a black text style
    Footnote anchor : Applied to the id in the main text area - superscript
    Endnote : based on default paragraph
    Endnote Symbol : Applied to the id in the endnote itself - just a black text style
    Endnote anchor : Applied to the id in the main text area - superscript
    
    BUG:306141
    BUG:323232


Diffs
-----

  libs/kotext/KoInlineNote.cpp ec8f4d0 
  libs/kotext/opendocument/KoTextSharedLoadingData.cpp 600ad37 
  libs/kotext/styles/KoStyleManager.cpp dc8bdfd 
  libs/odf/KoOdfNotesConfiguration.h 6395185 
  libs/odf/KoOdfNotesConfiguration.cpp ae6d8ac 
  libs/odf/KoOdfNumberDefinition.cpp 5670f9f 
  libs/odf/KoOdfStylesReader.cpp 2c0f5b2 
  libs/textlayout/KoTextLayoutNoteArea.cpp 0d1497d 
  plugins/textshape/dialogs/NotesConfigurationDialog.cpp 96aae3c 

Diff: https://git.reviewboard.kde.org/r/123195/diff/


Testing
-------

only manual testing


Thanks,

Camilla Boemann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150416/97f008fb/attachment.htm>


More information about the calligra-devel mailing list