<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123195/">https://git.reviewboard.kde.org/r/123195/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Camilla Boemann.</div>
<p style="color: grey;"><i>Updated April 16, 2015, 8:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit fc7b878f206fbf4e84e69bd18b2932eaa9c6e76e by C. Boemann to branch calligra/2.9.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The footnotes and endnotes were not displayed using the correct styles. We had just hard coded them to be shown using
superscript, but they should be done using the styles specified by the notes configuration.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">The same applies to the paragraph style of the note itself - but since this is just a default we didn't see any problem
when loading files, only when adding our own footnotes.
Now netiher of the 3 styles specified by the notes configuraion needs to be present in files, and indeed are not present in
our templates, so what LO does is add some styles. We do the same with these 6 styles
Footnote : based on default paragraph
Footnote Symbol : Applied to the id in the footnote itself - just a black text style
Footnote anchor : Applied to the id in the main text area - superscript
Endnote : based on default paragraph
Endnote Symbol : Applied to the id in the endnote itself - just a black text style
Endnote anchor : Applied to the id in the main text area - superscript
BUG:306141
BUG:323232
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">only manual testing</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoInlineNote.cpp <span style="color: grey">(ec8f4d0)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span style="color: grey">(600ad37)</span></li>
<li>libs/kotext/styles/KoStyleManager.cpp <span style="color: grey">(dc8bdfd)</span></li>
<li>libs/odf/KoOdfNotesConfiguration.h <span style="color: grey">(6395185)</span></li>
<li>libs/odf/KoOdfNotesConfiguration.cpp <span style="color: grey">(ae6d8ac)</span></li>
<li>libs/odf/KoOdfNumberDefinition.cpp <span style="color: grey">(5670f9f)</span></li>
<li>libs/odf/KoOdfStylesReader.cpp <span style="color: grey">(2c0f5b2)</span></li>
<li>libs/textlayout/KoTextLayoutNoteArea.cpp <span style="color: grey">(0d1497d)</span></li>
<li>plugins/textshape/dialogs/NotesConfigurationDialog.cpp <span style="color: grey">(96aae3c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123195/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>