Review Request 123324: Make kreport compile some more

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123324/#review78828
-----------------------------------------------------------


Reviewed in every details (I think) and I will integrate it myself. Notes below to show what are the common mistakes.


File Attachment: diff - kreport2.diff
<https://git.reviewboard.kde.org//r/123324/#fcomment393>

    These bits are delivered by extra-cmake-modules/kde-modules/KDECMakeSettings.cmake



File Attachment: diff - kreport2.diff
<https://git.reviewboard.kde.org//r/123324/#fcomment394>

    kreport_LIB_SRCS is enough



File Attachment: diff - kreport2.diff
<https://git.reviewboard.kde.org//r/123324/#fcomment395>

    found typo BTW!



File Attachment: diff - kreport2.diff
<https://git.reviewboard.kde.org//r/123324/#fcomment396>

    -> QLatin1Char(' ')


- Jarosław Staniek


On April 10, 2015, 5:17 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123324/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 5:17 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> In-progress fixing up of kreport by adding QLatin1String all over the place .... im not sure it will ever end!
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/123324/diff/
> 
> 
> Testing
> -------
> 
> It compiles a bit more!
> 
> 
> File Attachments
> ----------------
> 
> diff
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/93b54ca5-3ff6-471c-9279-5623885613b5__kreport2.diff
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150411/f12faf2c/attachment.htm>