<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123324/">https://git.reviewboard.kde.org/r/123324/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reviewed in every details (I think) and I will integrate it myself. Notes below to show what are the common mistakes.</p></pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/123324/file/2025/#source/line9" style="color: black; font-weight: bold; font-size: 9pt;">kreport2.diff</a>
<p>diff</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>9</th>
<td><pre><span class="gd">-#set(CMAKE_AUTOMOC ON)</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These bits are delivered by extra-cmake-modules/kde-modules/KDECMakeSettings.cmake</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/123324/file/2025/#source/line25" style="color: black; font-weight: bold; font-size: 9pt;">kreport2.diff</a>
<p>diff</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>25</th>
<td><pre><span class="gi">+qt5_wrap_ui(kreport_UI_HEADERS wrtembed/detailgroupsectiondialog.ui wrtembed/sectioneditor.ui)</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kreport_LIB_SRCS is enough</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/123324/file/2025/#source/line917" style="color: black; font-weight: bold; font-size: 9pt;">kreport2.diff</a>
<p>diff</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>917</th>
<td><pre><span class="gi">+ m_label->m_verticalAlignment->setValue(QLatin1String("mottom"));</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">found typo BTW!</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/123324/file/2025/#source/line1607" style="color: black; font-weight: bold; font-size: 9pt;">kreport2.diff</a>
<p>diff</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1607</th>
<td><pre><span class="gi">+ d->viewConverter->viewToDocumentX(line.length())) + QLatin1String("") + d->unit.symbol();</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-> QLatin1Char(' ')</p></pre>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On April 10th, 2015, 5:17 p.m. CEST, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated April 10, 2015, 5:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In-progress fixing up of kreport by adding QLatin1String all over the place .... im not sure it will ever end!</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles a bit more!</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123324/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/93b54ca5-3ff6-471c-9279-5623885613b5__kreport2.diff">diff</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>