Review Request 120696: Remove unimplemented KoCanvasResourceManager::undoStack/setUndoStack methods

Friedrich W. H. Kossebau kossebau at kde.org
Wed Oct 22 21:39:05 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120696/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 8:39 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra and Boudewijn Rempt.


Repository: calligra


Description
-------

When the resource manager for canvas and document was split in ebc7e6b8 in one per each, the methods `undoStack()` and `setUndoStack()` were also kept in the API of KoCanvasResourceManager, but without an implementation.

No idea if there should be one. Seems no code required that. So proposing to clean those two up.


Diffs
-----

  libs/flake/KoCanvasResourceManager.h af3378e 

Diff: https://git.reviewboard.kde.org/r/120696/diff/


Testing
-------

Still compiles ;)


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141022/19930985/attachment.htm>


More information about the calligra-devel mailing list