Review Request 120696: Remove unimplemented KoCanvasResourceManager::undoStack/setUndoStack methods
Sven Langkamp
sven.langkamp at gmail.com
Wed Oct 22 00:51:48 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120696/#review68863
-----------------------------------------------------------
Ship it!
Ship It!
- Sven Langkamp
On Okt. 21, 2014, 7:02 nachm., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120696/
> -----------------------------------------------------------
>
> (Updated Okt. 21, 2014, 7:02 nachm.)
>
>
> Review request for Calligra and Boudewijn Rempt.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> When the resource manager for canvas and document was split in ebc7e6b8 in one per each, the methods `undoStack()` and `setUndoStack()` were also kept in the API of KoCanvasResourceManager, but without an implementation.
>
> No idea if there should be one. Seems no code required that. So proposing to clean those two up.
>
>
> Diffs
> -----
>
> libs/flake/KoCanvasResourceManager.h af3378e
>
> Diff: https://git.reviewboard.kde.org/r/120696/diff/
>
>
> Testing
> -------
>
> Still compiles ;)
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141021/7c0839cd/attachment.htm>
More information about the calligra-devel
mailing list