Review Request 120612: Krita: save settings for ellipse tool

[Scott Petrovic]

> On Oct. 21, 2014, 5:12 p.m., Sven Langkamp wrote:
> > krita/ui/tool/kis_tool_shape.cc, line 67
> > <https://git.reviewboard.kde.org/r/120612/diff/2/?file=321088#file321088line67>
> >
> >     It could use toolId() here. That would work for all tools.

Yes. I like your idea about the tool id.


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120612/#review68827
-----------------------------------------------------------


On Oct. 21, 2014, 3:51 a.m., Scott Petrovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120612/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 3:51 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> load/save settings for ellipse tool
> 
> 
> Diffs
> -----
> 
>   krita/ui/tool/kis_tool_shape.cc 8762565 
>   krita/plugins/tools/defaulttools/kis_tool_ellipse.h f2ec9d1 
>   krita/plugins/tools/defaulttools/kis_tool_ellipse.cc bb74f66 
>   krita/ui/tool/kis_tool_shape.h b8d3f9c 
> 
> Diff: https://git.reviewboard.kde.org/r/120612/diff/
> 
> 
> Testing
> -------
> 
> loading and saving seemed to work.
> 
> 
> Thanks,
> 
> Scott Petrovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141021/6d62aaef/attachment.htm>