Review Request 120612: Krita: save settings for ellipse tool
Sven Langkamp
sven.langkamp at gmail.com
Tue Oct 21 18:12:33 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120612/#review68827
-----------------------------------------------------------
Ship it!
krita/ui/tool/kis_tool_shape.cc
<https://git.reviewboard.kde.org/r/120612/#comment48141>
It could use toolId() here. That would work for all tools.
- Sven Langkamp
On Okt. 21, 2014, 3:51 vorm., Scott Petrovic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120612/
> -----------------------------------------------------------
>
> (Updated Okt. 21, 2014, 3:51 vorm.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> load/save settings for ellipse tool
>
>
> Diffs
> -----
>
> krita/ui/tool/kis_tool_shape.cc 8762565
> krita/plugins/tools/defaulttools/kis_tool_ellipse.h f2ec9d1
> krita/plugins/tools/defaulttools/kis_tool_ellipse.cc bb74f66
> krita/ui/tool/kis_tool_shape.h b8d3f9c
>
> Diff: https://git.reviewboard.kde.org/r/120612/diff/
>
>
> Testing
> -------
>
> loading and saving seemed to work.
>
>
> Thanks,
>
> Scott Petrovic
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141021/aeb3cf9c/attachment.htm>
More information about the calligra-devel
mailing list