Review Request 120469: Deal with Glew not found, deduplicate linking to glew libs

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120469/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 5:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Arjen Hiemstra, Dan Leinir Turthra Jensen, and Boudewijn Rempt.


Repository: calligra


Description
-------

If Glew lib headers are not found, compilation fails with
```
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
GLEW_LIBRARY (ADVANCED)
    linked by target "kritaui" in directory [...]/calligra.master/krita/ui
    linked by target "kritasketch" in directory [...]/calligra.master/krita/sketch
    linked by target "kritasketch" in directory [...]/calligra.master/krita/sketch
    linked by target "kritasketchlib" in directory [...]/calligra.master/krita/sketch
    linked by target "kritasketchplugin" in directory [...]/calligra.master/krita/sketch
    linked by target "kritagemini" in directory [...]/calligra.master/krita/gemini
    linked by target "kritagemini" in directory [...]/calligra.master/krita/gemini

-- Configuring incomplete, errors occurred!
```
Attached patch fixes that by only using GLEW_LIBRARY to set GLEW_LIBRARIES if found.
It also removes a few duplicated listing of GLEW_LIBRARIES as libs to link to. I assume that duplication was not done on purpose, at least it links for me also this way.


Diffs
-----

  krita/CMakeLists.txt 18ba261 
  krita/gemini/CMakeLists.txt 9f1f64b 
  krita/ui/CMakeLists.txt 1aa4f64 
  cmake/modules/FindGLEW.cmake 2d76562 
  krita/sketch/CMakeLists.txt 46e0ba4 

Diff: https://git.reviewboard.kde.org/r/120469/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141015/7f209b0c/attachment.htm>