Review Request 120477: Unbreak build without Glew

Friedrich W. H. Kossebau kossebau at kde.org
Fri Oct 3 15:07:06 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120477/
-----------------------------------------------------------

Review request for Calligra, Dmitry Kazakov and Boudewijn Rempt.


Repository: calligra


Description
-------

KisOpenGLImageTextures::updateTextureFormat() some weeks ago got extended with code using variables (`colorModelId`, `destinationColorModelId`, etc) only declared inside an area guarded with `#ifdef HAVE_GLEW`. Which results in the compiler giving up with building when `HAVE_GLEW` is not defined.

Attached patch removes that reason for the compiler to be lazy, but I have not enough insight if that makes sense, so need your input.

Together with https://git.reviewboard.kde.org/r/120469/ applied Calligra/Krita builds without GLEW headers installed, and Krita starts up and works for the little bit I tested. Just the mouse cursor/brush is not seen over the canvas.


Diffs
-----

  krita/ui/opengl/kis_opengl_image_textures.cpp 643993d 

Diff: https://git.reviewboard.kde.org/r/120477/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141003/92d8d099/attachment.htm>


More information about the calligra-devel mailing list