Review Request 120594: Krita: save settings for rectangle tool

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120594/#review68491
-----------------------------------------------------------

Ship it!


Having separate reviews makes it a bit easier for me -- though I'm usually so behind that it might also become a liability. In any case, I first thought that saving the entries in the destructor would be enough, but that's not correct, your method is better. It's not really necessary to save the config group like you do, getting it is cheap enough, but it's not a problem either.

- Boudewijn Rempt


On Oct. 15, 2014, 3:34 a.m., Scott Petrovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120594/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 3:34 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Save Rectangle Tool settings to configuration. I had to modify the base class since the settings widget is created at that level. It should make adding other shape tool options easier when I do those. 
> 
> 
> Diffs
> -----
> 
>   krita/ui/tool/kis_tool_shape.h b9bbf6e 
>   krita/ui/tool/kis_tool_shape.cc 3e4c095 
>   krita/plugins/tools/defaulttools/kis_tool_rectangle.h b387d51 
>   krita/plugins/tools/defaulttools/kis_tool_rectangle.cc a00aa6a 
> 
> Diff: https://git.reviewboard.kde.org/r/120594/diff/
> 
> 
> Testing
> -------
> 
> Tested loading/saving with the kritarc file open.
> 
> Do I need to be putting every tool up for review when I add these? Not sure what you all would prefer. I am ok with either way.
> 
> 
> Thanks,
> 
> Scott Petrovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141015/f4773d9d/attachment.htm>