<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120594/">https://git.reviewboard.kde.org/r/120594/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Having separate reviews makes it a bit easier for me -- though I'm usually so behind that it might also become a liability. In any case, I first thought that saving the entries in the destructor would be enough, but that's not correct, your method is better. It's not really necessary to save the config group like you do, getting it is cheap enough, but it's not a problem either.</p></pre>
<br />
<p>- Boudewijn Rempt</p>
<br />
<p>On October 15th, 2014, 3:34 a.m. UTC, Scott Petrovic wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Scott Petrovic.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2014, 3:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Save Rectangle Tool settings to configuration. I had to modify the base class since the settings widget is created at that level. It should make adding other shape tool options easier when I do those. </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested loading/saving with the kritarc file open.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do I need to be putting every tool up for review when I add these? Not sure what you all would prefer. I am ok with either way.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/tool/kis_tool_shape.h <span style="color: grey">(b9bbf6e)</span></li>
<li>krita/ui/tool/kis_tool_shape.cc <span style="color: grey">(3e4c095)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_rectangle.h <span style="color: grey">(b387d51)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_rectangle.cc <span style="color: grey">(a00aa6a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120594/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>