Review Request 119245: Use a correct name for the library to be searched for

Friedrich W. H. Kossebau kossebau at kde.org
Wed Oct 15 18:04:16 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119245/#review68483
-----------------------------------------------------------


Ah, missed this one. Meanwhile have fixed that already by completely removing this check, as devs said that kdepimlibs is all or nothing during build time, so this check was not needed and just KDEPIMLIBS_FOUND as done a level up is enough.

- Friedrich W. H. Kossebau


On July 12, 2014, 12:02 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119245/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 12:02 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> CMake's find_library() accepts "canonical" names, like "kcal". There should be no prefix or suffix.
> 
> Please note that I do not have commit rights in KDE repos, so someone else should commit this patch if it gets accepted. Thanks.
> 
> 
> Diffs
> -----
> 
>   plan/plugins/filters/icalendar/CMakeLists.txt 99208d0 
> 
> Diff: https://git.reviewboard.kde.org/r/119245/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT, KDE 4.13.2
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141015/24b1ef69/attachment.htm>


More information about the calligra-devel mailing list