Review Request 119245: Use a correct name for the library to be searched for

Boudewijn Rempt boud at valdyas.org
Wed Oct 15 17:57:56 BST 2014



> On July 14, 2014, 10:28 p.m., Jarosław Staniek wrote:
> > Thanks a lot. Please someone commit it.
> 
> Vadim Zhukov wrote:
>     Yes, really, can someone please commit it? :)

Was this pushed? If not, jstaniek, can you push it and close the RR?


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119245/#review62347
-----------------------------------------------------------


On July 12, 2014, 12:02 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119245/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 12:02 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> CMake's find_library() accepts "canonical" names, like "kcal". There should be no prefix or suffix.
> 
> Please note that I do not have commit rights in KDE repos, so someone else should commit this patch if it gets accepted. Thanks.
> 
> 
> Diffs
> -----
> 
>   plan/plugins/filters/icalendar/CMakeLists.txt 99208d0 
> 
> Diff: https://git.reviewboard.kde.org/r/119245/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT, KDE 4.13.2
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141015/ed01d3b7/attachment.htm>


More information about the calligra-devel mailing list