Review Request 121256: Adding Vanishing Point, Inifite and Parallel Rulers to the assistants.

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121256/#review71015
-----------------------------------------------------------

Ship it!


- Boudewijn Rempt


On Nov. 26, 2014, 5:28 p.m., Wolthera van Hövell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121256/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 5:28 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Adding Vanishing Point, Inifite and Parallel Rulers to the assistants.
> 
> This is the second of the assistant work I am doing.
> It could still use some UI work, but in practice everything's working.
> 
> Vanishing-point: The vanishing point ruler pulls all snapped lines towards it. It uses 'side-handles' so you can have it aligned to exisitng lines in the drawing, while not having these nodes snap to eachother and cause bugs.
> Infinite: This is a ruler that draws a straight line into infinity.
> Parallel: Alike the infinite ruler, but it also draws line parallel.
> 
> NOTE: This was written against MVC, however, I did not touch anything in Krita/UI on purpose against this. It should build in master.
> 
> TODO:
> 
> * Make sure it builds in master once MVC is merged.
> * Make the drawing cache a bit larger.
> * Maybe make sidehandles look differently.
> * maybe make previews coloured(might become a different patch).
> * maybe make parallel and infite look prettier?
> 
> 
> Diffs
> -----
> 
>   krita/plugins/assistants/RulerAssistant/CMakeLists.txt 55a1c35 
>   krita/plugins/assistants/RulerAssistant/InfiniteRulerAssistant.h PRE-CREATION 
>   krita/plugins/assistants/RulerAssistant/InfiniteRulerAssistant.cc PRE-CREATION 
>   krita/plugins/assistants/RulerAssistant/ParallelRulerAssistant.h PRE-CREATION 
>   krita/plugins/assistants/RulerAssistant/ParallelRulerAssistant.cc PRE-CREATION 
>   krita/plugins/assistants/RulerAssistant/ruler_assistant_tool.cc de977a3 
>   krita/plugins/assistants/RulerAssistant/VanishingPointAssistant.h PRE-CREATION 
>   krita/plugins/assistants/RulerAssistant/VanishingPointAssistant.cc PRE-CREATION 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc b48d05b 
> 
> Diff: https://git.reviewboard.kde.org/r/121256/diff/
> 
> 
> Testing
> -------
> 
> I've done a few drawings with it.
> Is it right that assistants don't save into .kra files anymore? I thought they did. Ah wel..
> 
> 
> Thanks,
> 
> Wolthera van Hövell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141127/41c60549/attachment.htm>