<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121256/">https://git.reviewboard.kde.org/r/121256/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Boudewijn Rempt</p>
<br />
<p>On November 26th, 2014, 5:28 p.m. UTC, Wolthera van Hövell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Wolthera van Hövell.</div>
<p style="color: grey;"><i>Updated Nov. 26, 2014, 5:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adding Vanishing Point, Inifite and Parallel Rulers to the assistants.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is the second of the assistant work I am doing.
It could still use some UI work, but in practice everything's working.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Vanishing-point: The vanishing point ruler pulls all snapped lines towards it. It uses 'side-handles' so you can have it aligned to exisitng lines in the drawing, while not having these nodes snap to eachother and cause bugs.
Infinite: This is a ruler that draws a straight line into infinity.
Parallel: Alike the infinite ruler, but it also draws line parallel.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">NOTE: This was written against MVC, however, I did not touch anything in Krita/UI on purpose against this. It should build in master.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">TODO:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Make sure it builds in master once MVC is merged.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Make the drawing cache a bit larger.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Maybe make sidehandles look differently.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">maybe make previews coloured(might become a different patch).</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">maybe make parallel and infite look prettier?</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've done a few drawings with it.
Is it right that assistants don't save into .kra files anymore? I thought they did. Ah wel..</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/assistants/RulerAssistant/CMakeLists.txt <span style="color: grey">(55a1c35)</span></li>
<li>krita/plugins/assistants/RulerAssistant/InfiniteRulerAssistant.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/assistants/RulerAssistant/InfiniteRulerAssistant.cc <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/assistants/RulerAssistant/ParallelRulerAssistant.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/assistants/RulerAssistant/ParallelRulerAssistant.cc <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/assistants/RulerAssistant/ruler_assistant_tool.cc <span style="color: grey">(de977a3)</span></li>
<li>krita/plugins/assistants/RulerAssistant/VanishingPointAssistant.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/assistants/RulerAssistant/VanishingPointAssistant.cc <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc <span style="color: grey">(b48d05b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121256/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>