Review Request 120910: Action selection dialog: fix i18n argument, buddys, remove <html> tags

Mon Nov 24 23:57:50 GMT 2014

> On Nov. 25, 2014, 12:18 a.m., Friedrich W. H. Kossebau wrote:
> > kexi/formeditor/kexiactionselectiondialog.cpp, line 158
> > <https://git.reviewboard.kde.org/r/120910/diff/1/?file=323817#file323817line158>
> >
> >     Fixes the current problem, but in principle this still does not prevent other mark-up to appear. Next to <html> also <qt> is used as rich text wrapper (not sure though what is the right thing to use), and if there is such a wrapper, then also other mark-up is possible.
> >     IMHO it would be better, also for consistency, to always use the normal action text, and add the tooltips if present as tooltips.

We'll have to study this more later, in KF5 maybe.

- Jarosław

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120910/#review70875
-----------------------------------------------------------

On Oct. 31, 2014, 12:25 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120910/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 12:25 a.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Action selection dialog: fix i18n argument, buddys, remove <html> tags
> 
> + simplify the code a bit
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/kexiactionselectiondialog.cpp 1527152252fa3a344f5197ff03fd9b0cf67b9af3 
>   kexi/formeditor/kexiactionselectiondialog_p.h 161dcb00785f92d871fafdd7b97d709904d515ad 
> 
> Diff: https://git.reviewboard.kde.org/r/120910/diff/
> 
> 
> Testing
> -------
> 
> looks better
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141124/38feaf25/attachment.htm>