Review Request 120910: Action selection dialog: fix i18n argument, buddys, remove <html> tags

Mon Nov 24 23:18:42 GMT 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120910/#review70875
-----------------------------------------------------------

Ship it!

No regressions, but (minor) improvements, so good to go IMHO. Not sure that <html> removal is the best solution, surely can be made more tough :)

While looking at this, it seems that the column headers do not have the same margin like the columns, e.g. for me the text of 2nd and 3rd columns sometimes seem to be one text. Got lost when trying to find where margin/spacing is controlled, so just mentioning.
Also not sure that visual resolution of semantic markup (<interface>) is best... tried to enforce rich text resolution with using comment "@title/rich", but some reason that resulted in cut text for most categories. Just mentioning as well, nothing I would file a bug for :)

kexi/formeditor/kexiactionselectiondialog.cpp
<https://git.reviewboard.kde.org/r/120910/#comment49547>

    Fixes the current problem, but in principle this still does not prevent other mark-up to appear. Next to <html> also <qt> is used as rich text wrapper (not sure though what is the right thing to use), and if there is such a wrapper, then also other mark-up is possible.
    IMHO it would be better, also for consistency, to always use the normal action text, and add the tooltips if present as tooltips.

kexi/formeditor/kexiactionselectiondialog.cpp
<https://git.reviewboard.kde.org/r/120910/#comment49546>

    on one line, please -> "} else {"

- Friedrich W. H. Kossebau

On Okt. 30, 2014, 11:25 nachm., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120910/
> -----------------------------------------------------------
> 
> (Updated Okt. 30, 2014, 11:25 nachm.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Action selection dialog: fix i18n argument, buddys, remove <html> tags
> 
> + simplify the code a bit
> 
> 
> Diffs
> -----
> 
>   kexi/formeditor/kexiactionselectiondialog.cpp 1527152252fa3a344f5197ff03fd9b0cf67b9af3 
>   kexi/formeditor/kexiactionselectiondialog_p.h 161dcb00785f92d871fafdd7b97d709904d515ad 
> 
> Diff: https://git.reviewboard.kde.org/r/120910/diff/
> 
> 
> Testing
> -------
> 
> looks better
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141124/0b7a8309/attachment.htm>