Review Request 120933: Use LIB_INSTALL_DIR instead of CMAKE_INSTALL_LIBDIR to install QML files

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120933/
-----------------------------------------------------------

(Updated Nov. 12, 2014, 9 nachm.)


Status
------

This change has been discarded.


Review request for Calligra, Arjen Hiemstra and Boudewijn Rempt.


Repository: calligra


Description
-------

Krita Sketch and Gemini missed to find their qml files on Manjaro Linux. Reason was that all QML files are installed to lib64/, while the rest of the system assumed lib/ as path where the libs are installed. And Krita uses
    view->engine()->addImportPath(KGlobal::dirs()->findDirs("lib", "calligra/imports").value(0));
to get the QML files location, which of course returned the lib/ variant.

Looking around I see that CMAKE_INSTALL_LIBDIR is used as var to get the path where to install the QML files. Just, for some reason this var is resolved to lib64/ on Manjaro for whatever reason. Searching for this var I only found LIB_INSTALL_DIR on
http://www.cmake.org/cmake/help/v2.8.12/cmake.html which is also the main variable used in KDE code, cmp.
   http://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=LIB_INSTALL_DIR
with
   http://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=CMAKE_INSTALL_LIBDIR

Was there a reason CMAKE_INSTALL_LIBDIR was used? This patch fixes things for Manjaro, as Animtim tested, and also works for me.

Have not commited yet as it might break things on Windows ;) so asking for your review first, boud and arjen.


Diffs
-----

  krita/sketch/CMakeLists.txt c59a3be 
  krita/sketch/draganddrop/CMakeLists.txt a7c9068 

Diff: https://git.reviewboard.kde.org/r/120933/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141112/c7771484/attachment.htm>