<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120933/">https://git.reviewboard.kde.org/r/120933/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Arjen Hiemstra and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2014, 9 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Krita Sketch and Gemini missed to find their qml files on Manjaro Linux. Reason was that all QML files are installed to lib64/, while the rest of the system assumed lib/ as path where the libs are installed. And Krita uses
view->engine()->addImportPath(KGlobal::dirs()->findDirs("lib", "calligra/imports").value(0));
to get the QML files location, which of course returned the lib/ variant.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looking around I see that CMAKE_INSTALL_LIBDIR is used as var to get the path where to install the QML files. Just, for some reason this var is resolved to lib64/ on Manjaro for whatever reason. Searching for this var I only found LIB_INSTALL_DIR on
http://www.cmake.org/cmake/help/v2.8.12/cmake.html which is also the main variable used in KDE code, cmp.
http://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=LIB_INSTALL_DIR
with
http://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=CMAKE_INSTALL_LIBDIR</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Was there a reason CMAKE_INSTALL_LIBDIR was used? This patch fixes things for Manjaro, as Animtim tested, and also works for me.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have not commited yet as it might break things on Windows ;) so asking for your review first, boud and arjen.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/sketch/CMakeLists.txt <span style="color: grey">(c59a3be)</span></li>
<li>krita/sketch/draganddrop/CMakeLists.txt <span style="color: grey">(a7c9068)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120933/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>