Review Request 120634: Added possibility of painting kexi report rect elements in all directions

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120634/#review69657
-----------------------------------------------------------

Ship it!


Other than the minor for, good work, please push to master after fixing!


libs/koreport/items/image/KoReportDesignerItemImage.cpp
<https://git.reviewboard.kde.org/r/120634/#comment48806>

    Quick improvement: instead of hardcoding 100 in so many places how about using 
    const int KOREPORT_ITEM_RECT_DEFAULT_WIDTH = 100;
    const int KOREPORT_ITEM_RECT_DEFAULT_HEIGHT = 100;
    in KoReportDesignerItemRectBase.h or so?


- Jarosław Staniek


On Nov. 1, 2014, 6:10 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120634/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 6:10 p.m.)
> 
> 
> Review request for Calligra, Michal Poteralski, Adam Pigg, Jarosław Staniek, and Radosław Wicik.
> 
> 
> Bugs: 334967
>     http://bugs.kde.org/show_bug.cgi?id=334967
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Before there was only possible to paint kexi report rect element from leftup to rightdown. Now it's possible to paint the report element in any directio
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/web/KoReportDesignerItemWeb.h a1eb23b 
>   plugins/reporting/web/KoReportDesignerItemWeb.cpp b57f3c4 
>   libs/koreport/items/text/KoReportDesignerItemText.cpp 7af69c4 
>   libs/koreport/wrtembed/KoReportDesigner.h d27e263 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 2e1bd50 
>   libs/koreport/wrtembed/KoReportDesignerItemRectBase.h 1749270 
>   libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp 73b7a70 
>   plugins/reporting/barcode/KoReportDesignerItemBarcode.h 6e05375 
>   plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp 43acbd0 
>   plugins/reporting/maps/KoReportDesignerItemMaps.h 0bdf589 
>   plugins/reporting/maps/KoReportDesignerItemMaps.cpp d97a5ea 
>   libs/koreport/items/label/KoReportDesignerItemLabel.cpp 8bebbd2 
>   libs/koreport/items/text/KoReportDesignerItemText.h 3d79fbf 
>   libs/koreport/items/image/KoReportDesignerItemImage.cpp b129299 
>   libs/koreport/items/label/KoReportDesignerItemLabel.h 5aa3b48 
>   libs/koreport/items/image/KoReportDesignerItemImage.h ec0cf9c 
>   libs/koreport/items/field/KoReportDesignerItemField.h ec72324 
>   libs/koreport/items/field/KoReportDesignerItemField.cpp f386f9b 
>   libs/koreport/items/check/KoReportDesignerItemCheck.h 1bc4f5d 
>   libs/koreport/items/check/KoReportDesignerItemCheck.cpp ac62861 
> 
> Diff: https://git.reviewboard.kde.org/r/120634/diff/
> 
> 
> Testing
> -------
> 
> Possible to paint kexi report rect elements in any direction
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141101/fd57324d/attachment.htm>