<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120634/">https://git.reviewboard.kde.org/r/120634/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other than the minor for, good work, please push to master after fixing!</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120634/diff/3-4/?file=322180#file322180line63" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/items/image/KoReportDesignerItemImage.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 3 - 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoReportDesignerItemImage::init(QGraphicsScene *scene, KoReportDesigner *d)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setSceneRect</span><span class="p">(</span><span class="n">proper<span class="hl">PressPoin</span>t</span><span class="p">(</span><span class="o">*</span><span class="n">rw</span><span class="p"><span class="hl">),</span></span><span class="hl"> </span><span class="n"><span class="hl">minimumSize</span></span><span class="p"><span class="hl">(</span></span><span class="o"><span class="hl">*</span></span><span class="n"><span class="hl">rw</span></span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setSceneRect</span><span class="p">(</span><span class="n">proper<span class="hl">Rec</span>t</span><span class="p">(</span><span class="o">*</span><span class="n">rw</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">100</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">100</span></span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Quick improvement: instead of hardcoding 100 in so many places how about using
const int KOREPORT_ITEM_RECT_DEFAULT_WIDTH = 100;
const int KOREPORT_ITEM_RECT_DEFAULT_HEIGHT = 100;
in KoReportDesignerItemRectBase.h or so?</p></pre>
</div>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On November 1st, 2014, 6:10 p.m. CET, Wojciech Kosowicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Michal Poteralski, Adam Pigg, Jarosław Staniek, and Radosław Wicik.</div>
<div>By Wojciech Kosowicz.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2014, 6:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334967">334967</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before there was only possible to paint kexi report rect element from leftup to rightdown. Now it's possible to paint the report element in any directio</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Possible to paint kexi report rect elements in any direction</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/reporting/web/KoReportDesignerItemWeb.h <span style="color: grey">(a1eb23b)</span></li>
<li>plugins/reporting/web/KoReportDesignerItemWeb.cpp <span style="color: grey">(b57f3c4)</span></li>
<li>libs/koreport/items/text/KoReportDesignerItemText.cpp <span style="color: grey">(7af69c4)</span></li>
<li>libs/koreport/wrtembed/KoReportDesigner.h <span style="color: grey">(d27e263)</span></li>
<li>libs/koreport/wrtembed/KoReportDesigner.cpp <span style="color: grey">(2e1bd50)</span></li>
<li>libs/koreport/wrtembed/KoReportDesignerItemRectBase.h <span style="color: grey">(1749270)</span></li>
<li>libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp <span style="color: grey">(73b7a70)</span></li>
<li>plugins/reporting/barcode/KoReportDesignerItemBarcode.h <span style="color: grey">(6e05375)</span></li>
<li>plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp <span style="color: grey">(43acbd0)</span></li>
<li>plugins/reporting/maps/KoReportDesignerItemMaps.h <span style="color: grey">(0bdf589)</span></li>
<li>plugins/reporting/maps/KoReportDesignerItemMaps.cpp <span style="color: grey">(d97a5ea)</span></li>
<li>libs/koreport/items/label/KoReportDesignerItemLabel.cpp <span style="color: grey">(8bebbd2)</span></li>
<li>libs/koreport/items/text/KoReportDesignerItemText.h <span style="color: grey">(3d79fbf)</span></li>
<li>libs/koreport/items/image/KoReportDesignerItemImage.cpp <span style="color: grey">(b129299)</span></li>
<li>libs/koreport/items/label/KoReportDesignerItemLabel.h <span style="color: grey">(5aa3b48)</span></li>
<li>libs/koreport/items/image/KoReportDesignerItemImage.h <span style="color: grey">(ec0cf9c)</span></li>
<li>libs/koreport/items/field/KoReportDesignerItemField.h <span style="color: grey">(ec72324)</span></li>
<li>libs/koreport/items/field/KoReportDesignerItemField.cpp <span style="color: grey">(f386f9b)</span></li>
<li>libs/koreport/items/check/KoReportDesignerItemCheck.h <span style="color: grey">(1bc4f5d)</span></li>
<li>libs/koreport/items/check/KoReportDesignerItemCheck.cpp <span style="color: grey">(ac62861)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120634/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>