Review Request 117966: Updated script for generating databases keywords in Kexi
Wojciech Kosowicz
pcellix at gmail.com
Fri May 16 23:17:42 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117966/
-----------------------------------------------------------
(Updated May 16, 2014, 10:17 p.m.)
Review request for Calligra and Jarosław Staniek.
Changes
-------
* now all the extracted files are stored within /tmp directory
* after script finishes files are moved to proper locations (first ensuring that files already existed in locations)
* 4th argument added to call script - path to calligra source directory
* files are not deleted manually (temporary directory will get deleted automatically)
Repository: calligra
Description
-------
This patch contains changes for sql_keywords.sh script that generates source files that contains keywords for specific database technology (kexisql, sqlite, postrsql, mysql).
I did my best still I think functions getPostgreSQLKeywords and getSQLiteKeywords can be done in a better (old mechanism did not work but I think there can be better ways than what I came up with.
Every suggestions are welcome
TODO:
updating comments as some functions changed names/attributes
Diffs (updated)
-----
kexi/tools/sql_keywords/sql_keywords.sh 6bcc5de
Diff: https://git.reviewboard.kde.org/r/117966/diff/
Testing
-------
4 files that contained keywords are generated and they do contain them
Thanks,
Wojciech Kosowicz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140516/08feb388/attachment.htm>
More information about the calligra-devel
mailing list