Review Request 117966: Updated script for generating databases keywords in Kexi

[Wojciech Kosowicz]

> On May 15, 2014, 9:32 p.m., Jarosław Staniek wrote:
> > Security hazard in rm -rf "$appVer": please let's never remove full path from such commands. One mistake and you'd delete ~.

I have a question regarding this because $appVer is not a full path (I understand fullpath is something like /home/a/vb/ in this case it would just be vb) or do I dont understand meaning? Is it in regard to deleting whole directory?


- Wojciech


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117966/#review58037
-----------------------------------------------------------


On May 14, 2014, 11:08 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117966/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 11:08 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch contains changes for sql_keywords.sh script that generates source files that contains keywords for specific database technology (kexisql, sqlite, postrsql, mysql). 
> I did my best still I think functions getPostgreSQLKeywords and getSQLiteKeywords can be done in a better (old mechanism did not work but I think there can be better ways than what I came up with.
> Every suggestions are welcome
> TODO:
> updating comments as some functions changed names/attributes
> 
> 
> Diffs
> -----
> 
>   kexi/tools/sql_keywords/sql_keywords.sh 6bcc5de 
> 
> Diff: https://git.reviewboard.kde.org/r/117966/diff/
> 
> 
> Testing
> -------
> 
> 4 files that contained keywords are generated and they do contain them
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140515/9d24b710/attachment.htm>