Review Request 117966: Updated script for generating databases keywords in Kexi

[Jaroslaw Staniek]

On 14 May 2014 22:21, Wojciech Kosowicz <pcellix at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117966/
>
> On May 14th, 2014, 8:15 p.m. UTC, *Jarosław Staniek* wrote:
>
> I am using:
> ./sql_keywords.sh /tmp/sqlite-src-3080403.zip /tmp/mysql-5.6.17.tar.gz /tmp/postgresql-9.3.4.tar.gz
>
> Please try this case.
>
> Matching does not work because the code such as [[ ! $sqlArchive == sqlite*.zip ]] expects filename without a path. Better do not expect people to save the archives in source dir calligra/kexi/tools/sql_keywords/.
>
>  what do you think about? [[ ! $sqlArchive == *sqlite*.zip ]] i guess it should work for all cases
>
>
>
​Yes, should work.
​


>  - Wojciech
>
> On May 14th, 2014, 7:45 p.m. UTC, Wojciech Kosowicz wrote:
>   Review request for Calligra and Jarosław Staniek.
> By Wojciech Kosowicz.
>
> *Updated May 14, 2014, 7:45 p.m.*
>  *Repository: * calligra
> Description
>
> This patch contains changes for sql_keywords.sh script that generates source files that contains keywords for specific database technology (kexisql, sqlite, postrsql, mysql).
> I did my best still I think functions getPostgreSQLKeywords and getSQLiteKeywords can be done in a better (old mechanism did not work but I think there can be better ways than what I came up with.
> Every suggestions are welcome
> TODO:
> updating comments as some functions changed names/attributes
>
>   Testing
>
> 4 files that contained keywords are generated and they do contain them
>
>   Diffs
>
>    - kexi/tools/sql_keywords/sql_keywords.sh (6bcc5de)
>
> View Diff <https://git.reviewboard.kde.org/r/117966/diff/>
>



-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt for Tizen | http://qt-project.org/wiki/Tizen
 Qt Certified Specialist | http://www.linkedin.com/in/jstaniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140514/9dc75e83/attachment.htm>